Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat 0 as false value #51

Merged
merged 1 commit into from
Apr 7, 2023
Merged

fix: treat 0 as false value #51

merged 1 commit into from
Apr 7, 2023

Conversation

mrexox
Copy link
Contributor

@mrexox mrexox commented Apr 7, 2023

Closes coverallsapp/orb#28

⚡ Summary

Treat 0 as falsey value of COVERALLS_PARALLEL

@mrexox mrexox mentioned this pull request Apr 7, 2023
Closed
@coveralls
Copy link
Member

Pull Request Test Coverage Report for Build 4636394059

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.815%
Totals Coverage Status
Change from base Build 4627625178: 0.0%
Covered Lines: 679
Relevant Lines: 756
💛 - Coveralls

@mrexox mrexox changed the title fix: add 0 as false value fix: treat 0 as false value Apr 7, 2023
@mrexox mrexox merged commit 668188e into coverallsapp:master Apr 7, 2023
@mrexox mrexox deleted the fix/add-0-as-false-value branch April 7, 2023 07:37
@zackse
Copy link

zackse commented Apr 7, 2023

Thanks for the quick turnaround on this, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrexox @coveralls @zackse